Closed
Bug 263255
Opened 20 years ago
Closed 20 years ago
Improve thread pane UI for message grouping
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird0.9
People
(Reporter: mscott, Assigned: mscott)
Details
(Keywords: fixed-aviary1.0)
Attachments
(6 files, 1 obsolete file)
32.17 KB,
image/png
|
Details | |
17.62 KB,
image/png
|
Details | |
6.90 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
2.57 KB,
patch
|
Details | Diff | Splinter Review | |
patch to get rid of column re-ordering, make all attributes group with dummy rows except for subject
10.44 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
50.93 KB,
image/png
|
Details |
Tracking bug for some CSS improvements I hope to make to build off of David's great grouping feature.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.9
Assignee | ||
Comment 1•20 years ago
|
||
Here are a couple of different looks...
Assignee | ||
Comment 2•20 years ago
|
||
Assignee | ||
Comment 3•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #161385 -
Flags: superreview?(bienvenu)
Comment 4•20 years ago
|
||
Comment on attachment 161385 [details] [diff] [review] patch for some UI improvements for grouping I'm a little torn about removing the thread column, since it could be used to switch to normal threaded mode, if it worked, but it does look cleaner without it...
Attachment #161385 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 5•20 years ago
|
||
Other things I'd like to try to address here: 1) Adding a customizeable toolbar button for popping you in and out of grouped mode, making this feature more visible. 2) I need to do some mac osx theme work to make this work for Mac 3) For messages from yesterday, maybe just showing the time instead of a date stamp on the msg. 4) double clicking a dummy group row causes us to open the next msg in a stand alone window....
Assignee | ||
Comment 6•20 years ago
|
||
Kevin will probably want to style this in a nice OS X friendly fashion but this gets us going.
Assignee | ||
Comment 7•20 years ago
|
||
Comment on attachment 162136 [details] [diff] [review] some CSS to get grouping going on Mac OS X wrong patch
Attachment #162136 -
Attachment is obsolete: true
Assignee | ||
Comment 8•20 years ago
|
||
Assignee | ||
Comment 9•20 years ago
|
||
the OS X style rules have been checked into the branch and the trunk but they could use some more OS X specific polish.
Assignee | ||
Comment 10•20 years ago
|
||
Assignee | ||
Comment 11•20 years ago
|
||
Comment on attachment 162668 [details] [diff] [review] patch to get rid of column re-ordering, make all attributes group with dummy rows except for subject David, what do you think of this patch? 1) No more column re-ordering 2) as we discussed all sort attributes except for the subject now use dummy rows 3) Some of our sort attributes like priority, lable and status have states with no title text so I had to make up some entries such as "No Status" or "No Priority" to show up in the UI for that particular container. 4) I'd like to get rid of the code that shows/hides the thread icon next but am still mulling that over. I'm sure I broke something in here when toggling back and forth between group by sorted, threaded mode, etc. with my threadpane.js changes :)
Attachment #162668 -
Flags: superreview?(bienvenu)
Comment 12•20 years ago
|
||
Comment on attachment 162668 [details] [diff] [review] patch to get rid of column re-ordering, make all attributes group with dummy rows except for subject looks good, thx, Scott!
Attachment #162668 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 13•20 years ago
|
||
screen shot to show off how grouping now looks when you are sorted by attributes like Label and Date. Subject is now the only one that won't use these dummy rows.
Assignee | ||
Comment 14•20 years ago
|
||
I think we've gotten enough mileage out of this bug. Further improvements can be handled in separate bugs. Closing this out. All of the patches are in the branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Keywords: fixed-aviary1.0
Comment 15•20 years ago
|
||
Minor nit: The "mark as deleted" icon (envelope with red X) doesn't appear in grouped view.
Assignee | ||
Comment 16•20 years ago
|
||
Hmm that worked for me Peter using todays build. I went into grouped mode by date. Deleted a message and saw the red X next to the icon. Are you using the default theme? I"m sure most themes haven't been updated to work right with groups yet.
Comment 17•20 years ago
|
||
(In reply to comment #16) version 0.8 (20041021), winXP, default theme (plus "purge" button extension <- should be in default theme, BTW), IMAP, setting: mark as deleted, sort by date, send e-mail to self, select message, press g, re-select message, click delete button -> message's envelope icon is *not* marked with red X.
Comment 18•20 years ago
|
||
(In reply to comment #17) > version 0.8 (20041021), winXP, default theme (plus "purge" button extension <- > should be in default theme, BTW), IMAP, setting: mark as deleted, sort by date, > send e-mail to self, select message, press g, re-select message, click delete > button -> message's envelope icon is *not* marked with red X. I repeated your steps with version 1.0 (20041206) and all behaves well. Peter can you test again with a recent version? Perhaps this could be fixed by the theme update before 1.0.
Comment 19•20 years ago
|
||
(In reply to comment #18) > Peter can you test again with a recent version? OK, it works now - Thunderbird "version 1.0 (20041212)" BTW: It would be nice if the selected message *stayed selected* when toggling between grouped and listed views. (I never use grouped view)
You need to log in
before you can comment on or make changes to this bug.
Description
•